server/lib/notifications/agents/ntfy.ts (1)

38-41: Avoid leading blank lines when request message starts empty.

On Line 41 and Line 64, unconditional newline prefixes can produce a notification body that starts with empty lines.

💡 Minimal diff

-      message += `\n\n**- Requested By:** ${payload.request.requestedBy.displayName}`;
+      message += `${message ? '\n\n' : ''}**- Requested By:** ${payload.request.requestedBy.displayName}`;
…
-        message += `\n**- Request Status:** ${status}`;
+        message += `${message ? '\n' : ''}**- Request Status:** ${status}`;

Also applies to: 64-64

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@server/lib/notifications/agents/ntfy.ts` around lines 38 - 41, The
message-building logic in ntfy.ts currently prepends or appends sections with
unconditional "\n\n" which can produce leading blank lines when the initial
message is empty; update the code that mutates the variable message (the block
that sets message = `**- Description:**\n${message}` and the later append that
adds `\n\n**- Requested By:** ${payload.request.requestedBy.displayName}`) to
conditionally add the preceding newlines only when message is non-empty,
otherwise set the section text without leading blank lines so the final
notification body never starts with empty lines.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

server/lib/notifications/agents/ntfy.ts (1)

41-45: Consider extracting a tiny section-builder helper for repeated string assembly.

The same “prepend/append labeled block with conditional spacing” pattern appears in multiple branches; a helper would reduce drift in future edits.

Also applies to: 71-75, 77-83

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@server/lib/notifications/agents/ntfy.ts` around lines 41 - 45, Extract the
repeated "prepend/append labeled block with conditional spacing" logic into a
small helper (e.g., appendLabeledBlock(existingMessage, label, content)) inside
ntfy.ts and use it wherever that pattern appears: replace the payload.request
branch that manipulates message, the similar block around lines 71-75, and the
block at 77-83; the helper should take the current message string, a label like
"Description" or "Requested By", and the escaped content (use
this.escapeMarkdown(payload.request.requestedBy.displayName) when appropriate),
and return the new message string with correct spacing and formatting so callers
(the code touching message and payload.request) just call the helper instead of
manually concatenating.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro